Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadPoolConfigCopyAdvice often sets null prereqs #1365

Closed
wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

Found when testing #1352

Even when testing with Scala 2.12, I see that the set in this PR often sets null
1352 affects Scala 2.13 far more than Scala 2.12.

@hughsimpson
Copy link
Contributor

I'm not sure that this would work... the copy will be instantiated with null values on those fields anyway, so not sure this actually defends against anything?

@pjfanning
Copy link
Contributor Author

pjfanning commented Sep 20, 2024

I'm not sure that this would work... the copy will be instantiated with null values on those fields anyway, so not sure this actually defends against anything?

I just feel that it is possible the prereqs could have been populated by a different instrumentation point and the risk is that a valid value stored on the instance could be replaced by a later set call that adds a null. There are a couple of other instrumentation points that set prereqs values.

@hughsimpson
Copy link
Contributor

hughsimpson commented Sep 21, 2024

I can't see any intervention pathway where that would be possible, short of constructor advice pulling it from context.. and then how do you get it into the constructor context if not here?

@hughsimpson
Copy link
Contributor

I'm gonna close this, I think it's the wrong approach

@hughsimpson hughsimpson closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants